Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (strings) Non plain English, non translatable property name in queueUpdate() success message #37538

Open
5 of 9 tasks
silopolis opened this issue Apr 1, 2023 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: language l10n and translations

Comments

@silopolis
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

The queueUpdate() success message uses the share's raw property name, which is not that English users friendly and not translatable.

Plus, my shamy PHP non-skills make me believe that it doesn't return all properties when several properties are passed to queueUpdate().

https://github.com/nextcloud/server/blob/master/apps/files_sharing/src/mixins/SharesMixin.js#L280

Steps to reproduce

Update share properties and get a success message

Expected behavior

Have user messages in plain English and translatable, whether one or several properties are passed to queueUpdate().

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Files

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@silopolis silopolis added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Apr 1, 2023
@silopolis silopolis changed the title [Bug]: [Bug]: (strings) Non plain English, non translatable property name in queueUpdate() success message Apr 1, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 1, 2023

cc @Pytal

@Pytal
Copy link
Member

Pytal commented Apr 4, 2023

This would need a mapping between the property name and readable string for all properties passed to queueUpdate() https://github.com/search?q=repo%3Anextcloud%2Fserver+queueUpdate&type=code

And yes since there may be multiple properties (introduced in #20938) we'd have to show each one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: language l10n and translations
Projects
None yet
Development

No branches or pull requests

4 participants