Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android browsers: App Mode - Full Screen / No Address Bar #4047

Closed
Huster-at-github opened this issue Mar 25, 2017 · 13 comments
Closed

Android browsers: App Mode - Full Screen / No Address Bar #4047

Huster-at-github opened this issue Mar 25, 2017 · 13 comments
Assignees
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@Huster-at-github
Copy link

Huster-at-github commented Mar 25, 2017

Firefox and Chrome have the possibility to run web sites in "App Mode".

Example: Chrome withFM4 Radio Station:
image

Currently it looks like this in

Firefox:
image

Chrome:
image

@nickvergessen nickvergessen added the design Design, UI, UX, etc. label Mar 25, 2017
@MorrisJobke
Copy link
Member

@jancborchardt That's what I meant with "the current CSS is awkward", because we don't scroll the whole page but we scroll inside a fixed container, which breaks basically this browser feature 😉

@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@jancborchardt
Copy link
Member

I think this is different, because the Radio FM4 page is not scrolled either, right?

@Huster-at-github do you want to contribute a pull request to fix it? :)

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Mar 27, 2017
@Espina2
Copy link
Contributor

Espina2 commented Mar 27, 2017

Why not just center the container with login, and have background cover for main div?

It should work just fine.

@eppfel
Copy link
Member

eppfel commented Mar 27, 2017

No, I think @MorrisJobke is right. Works fine with scrolling as well. And this is related to the complete site, not just the login.

@Huster-at-github FM4 😍

@jancborchardt
Copy link
Member

Well the issue here is that we have a fixed header. Anyone have a good idea around this?

@jancborchardt
Copy link
Member

There is also this quite nice library for hiding the header – we could hide the Nextcloud header itself with this: http://wicky.nillia.ms/headroom.js/

@MorrisJobke
Copy link
Member

Well the issue here is that we have a fixed header. Anyone have a good idea around this?

No. The reason is, that we have 100% height fixed and in there a scroll area (the app-content).

There is also this quite nice library for hiding the header – we could hide the Nextcloud header itself with this: http://wicky.nillia.ms/headroom.js/

no way - why add a JS library where we also can cleanup our mess first and then look into further fixes.

@Espina2
Copy link
Contributor

Espina2 commented Mar 28, 2017

There is also this quite nice library for hiding the header – we could hide the Nextcloud header itself with this: http://wicky.nillia.ms/headroom.js/

BTW, Im using that on the Website.

@Vetm
Copy link

Vetm commented Jul 23, 2017

I think you guys misunterstood @Huster-at-github 's problem. It is not about the url-bar hiding when scrolling down.

On Chrome and Firefox for Android you can add a webpage to the homescreen so it can be launched like an app. There is also a feature where you can hide the url-bar so the webpage actually feels like a native app.

To use this feature you just have to some simple steps as described here.

I'd be happy to fix this issue.

@jancborchardt
Copy link
Member

@Vetm sorry for the late reply – it would be awesome if you can fix this issue. :) You are very welcome to open a pull request!

@juliushaertl
Copy link
Member

As a hint for anyone who wants to dig into this starter issue: We already have a manifest.json file. It seems like it is just loaded for logged in users and not on the login page.

@skjnldsv skjnldsv self-assigned this Dec 21, 2017
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed design Design, UI, UX, etc. labels Jun 25, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 25, 2018
@skjnldsv skjnldsv added the design Design, UI, UX, etc. label Jun 25, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jun 25, 2018
@MorrisJobke
Copy link
Member

Fix is in #9982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

10 participants