Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] Replace all places with old NcMultiselect components with NcSelect components #40588

Closed
JuliaKirschenheuter opened this issue Sep 22, 2023 · 2 comments · Fixed by #41581
Closed

[BITV] Replace all places with old NcMultiselect components with NcSelect components #40588

JuliaKirschenheuter opened this issue Sep 22, 2023 · 2 comments · Fixed by #41581
Assignees
@susnux
Labels
3. to review Waiting for reviews accessibility bug
Milestone
Nextcloud 28

Comments

@JuliaKirschenheuter
Copy link
Contributor

There are still several places in our views where NcMultiselect components are used. Due to several reasons (inclusive contrast issues) we have to switch completely to NcSelect components.

Examples:

index.php/settings/admin/sharing
Screenshot from 2023-09-22 14-50-22

index.php/settings/admin
Screenshot from 2023-09-22 15-05-16
@JuliaKirschenheuter JuliaKirschenheuter added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 22, 2023
@susnux susnux self-assigned this Oct 2, 2023
@susnux
Copy link
Contributor

susnux commented Oct 2, 2023

@JuliaKirschenheuter there are no NcMultiselect components anymore in the server.
The tags selector of the second screeshot is already a NcSelect (NcSelectTags).

@susnux
Copy link
Contributor

susnux commented Oct 2, 2023

For the first one: We need to migrate the legacy settings then to Vue (currently still jQuery)

@susnux susnux removed their assignment Nov 1, 2023
@susnux susnux self-assigned this Nov 9, 2023
@susnux susnux mentioned this issue Nov 15, 2023
Closed
4 tasks
@susnux susnux added bug 2. developing Work in progress accessibility and removed enhancement 1. to develop Accepted and waiting to be taken care of labels Nov 16, 2023
@susnux susnux added this to the Nextcloud 28 milestone Nov 16, 2023
@susnux susnux mentioned this issue Nov 17, 2023
Merged
3 tasks
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 17, 2023
@mawumag mawumag mentioned this issue Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
3. to review Waiting for reviews accessibility bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging a pull request may close this issue.

enh(settings): Migrate admin settings for sharing to vue nextcloud/server
2 participants
@susnux @JuliaKirschenheuter