Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: F2V: Not possible to enter credentials for external storage #40776

Closed
artonge opened this issue Oct 5, 2023 · 4 comments · Fixed by #40782
Closed

[Bug]: F2V: Not possible to enter credentials for external storage #40776

artonge opened this issue Oct 5, 2023 · 4 comments · Fixed by #40782
Labels
Milestone

Comments

@artonge
Copy link
Contributor

artonge commented Oct 5, 2023

Bug description

When the authentication method for an external storage is set to "User entered, store in database", the file view should display a form to allow the user to enter the credentials.

This was previously done by: https://github.com/nextcloud/server/blob/stable26/apps/files_external/js/statusmanager.js#L389

And I do not see any modal opening in the current implementation: https://github.com/nextcloud/server/blob/7e5e8873070b7fd3071a5eaab5ed467686baa774/apps/files_external/src/actions/enterCredentialsAction.ts#L76-L77

Might be looking at the wrong place. But I was not able to trigger any modal during my testing.

Steps to reproduce

  1. Create an external storage
  2. Set the authentication method to "User entered, store in database"
  3. Go to the F2V file list
  4. Click on the external storage
  5. Nothing happens

Expected behavior

A modal should be displayed to prompt the user for credentials.

Nextcloud Server version

master

@skjnldsv

@artonge artonge added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 5, 2023
@artonge artonge added this to the Nextcloud 28 milestone Oct 5, 2023
@artonge artonge changed the title [Bug]: F2V Not possible to enter credentials for external storage [Bug]: F2V: Not possible to enter credentials for external storage Oct 5, 2023
@artonge artonge added this to Legacy bugs in Files to vue via automation Oct 5, 2023
@artonge artonge moved this from Legacy bugs to Potential regressions in Files to vue Oct 5, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2023

@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2023

And I do not see any modal opening in the current implementation:

We're using a request for this. Your browser should display a login modal. This is not from a component, this is a vanilla http auth modal.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2023

Ah, it works in the external_storage view.
Not in the main files view 🤔

I think the config is not fetched, we should do that async, or redirect to the external_storage view if the storage has failed 🤔
image

@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2023

Ah, this is due to the axios library update...

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 5, 2023
Files to vue automation moved this from Potential regressions to Done Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Files to vue
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants