Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder Smart Picker broken #40866

Closed
jospoortvliet opened this issue Oct 9, 2023 · 5 comments
Closed

Folder Smart Picker broken #40866

jospoortvliet opened this issue Oct 9, 2023 · 5 comments
Assignees
Labels

Comments

@jospoortvliet
Copy link
Member

Describe the bug
The folder/file smart picker in Office seems broken.
First, it forgets its last used location, every time I open it I have to navigate 6 layers deep again. second, the links it then adds are broken.

Also, the top navigation bar where you pick the smart picker doesn't stick with what I choose, adding extra mouse clicks as well.

To Reproduce
Steps to reproduce the behavior:

  1. Open a document, go to insert
  2. choose smart picker and go for folder
  3. insert a file
  4. see a broken link

Expected behavior
A working link

Screenshots
How about a video:
https://cloud.nextcloud.com/f/7915124
(internally shared to office chat room, sorry for external ppl...)

Client details:
Mac OS, Firefox, both in Writer and Spreadsheet

Server details

Nextcloud version:
*

  • 27.2.2
  • COOLWSD version: 23.05.3.1 git hash: a719c0f
  • LOKit version: built on Collabora Office 23.05.3.1 git hash: 403de15
  • Served by: Ubuntu 22.04.3 LTS
  • 9002c172
@juliushaertl juliushaertl transferred this issue from nextcloud/richdocuments Oct 11, 2023
@juliushaertl juliushaertl added bug 1. to develop Accepted and waiting to be taken care of labels Oct 11, 2023
@juliushaertl
Copy link
Member

Can reproduce, likely a regression from the new file picker dialog

@juliushaertl juliushaertl self-assigned this Oct 11, 2023
@juliushaertl
Copy link
Member

Relevant code part

OC.dialogs.filepicker(
t('files', 'Select file or folder to link to'),
(file) => {
const client = OC.Files.getClient()
client.getFileInfo(file).then((_status, fileInfo) => {
this.submit(fileInfo.id)
})
},
false, // multiselect
[], // mime filter
false, // modal
FilePickerType.Choose, // type
'',
{
target: this.$refs.picker,
},
)

@small1
Copy link

small1 commented Nov 3, 2023

I noice this in the text app. If we pick form a group folder we get a broken link

@jospoortvliet
Copy link
Member Author

So this is broken everywhere in Nextcloud, also in Text & Collectives and Talk. Also, the dialog is missing thumbnails for me:
Screenshot_20231207_131910

@susnux
Copy link
Contributor

susnux commented Dec 7, 2023

the dialog is missing thumbnails for me

Fixed with #42057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants