Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clearing reminders on files #41368

Closed
Pytal opened this issue Nov 9, 2023 · 4 comments · Fixed by #43560
Closed

Allow clearing reminders on files #41368

Pytal opened this issue Nov 9, 2023 · 4 comments · Fixed by #43560

Comments

@Pytal
Copy link
Member

Pytal commented Nov 9, 2023

The clear reminder action should be available if a reminder exists

On 27:
image

Not sure about implementation as FileAction enabled() is not awaitable

Previously a request was made to the backend to check if a reminder was set

dueDate = (await getReminder(fileId)).dueDate

@Pytal Pytal added enhancement 1. to develop Accepted and waiting to be taken care of feature: files regression labels Nov 9, 2023
@Pytal
Copy link
Member Author

Pytal commented Nov 9, 2023

Any ideas on how we could go about this would be much appreciated @skjnldsv :)

@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2023

Just add a dedicated action ?
You can do the request in the enabled async method, or (better), have the reminder be present as a dav attribute ?

@Pytal Pytal added this to the Nextcloud 29 milestone Dec 6, 2023
@Pytal Pytal self-assigned this Dec 6, 2023
@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Feb 10, 2024
@XueSheng-GIT
Copy link

@Pytal I'm on NC 28.0.2 and once a reminder is set, I cannot even see whether a reminder is set or not (there is no such indication). Is this part and covered by this issue?

@Pytal
Copy link
Member Author

Pytal commented Feb 13, 2024

No, that is not covered by this issue @XueSheng-GIT but I will do that in a followup

Tracking in #43540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants