Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.4.11/7.2 - When selecting a new color for the background, which is indicated by a checkmark, this checkmark does not meet the contrast requirements, as the contrast ratio with the background is below 3:1. (1) #41861

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#4958
Closed

[BITV] 9.1.4.11/7.2 - When selecting a new color for the background, which is indicated by a checkmark, this checkmark does not meet the contrast requirements, as the contrast ratio with the background is below 3:1. (1) #41861

JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#4958
Assignees
@emoral435
Labels
4. to release Ready to be released and/or waiting for tests to finish a11y28checked needed for a11y accessibility feature: settings

Comments

@JuliaKirschenheuter
Copy link
Contributor

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3dbfb7615a-v7-n2
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 30, 2023
@susnux
Copy link
Contributor

susnux commented Nov 30, 2023

vue component issue, probably the check icon colors needs to be calculated from the background color

@ShGKme
Copy link
Contributor

ShGKme commented Dec 11, 2023

And probably we should add the same border as on background selector

@emoral435 emoral435 self-assigned this Dec 12, 2023
@emoral435 emoral435 mentioned this issue Dec 13, 2023
Merged
2 tasks
@ShGKme ShGKme reopened this Dec 22, 2023
@emoral435
Copy link
Contributor

Once #42499 gets merged, this should be closed :)

@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish feature: settings and removed 1. to develop Accepted and waiting to be taken care of pending dependency update labels Jan 2, 2024
@ShGKme ShGKme removed their assignment Jan 2, 2024
@szaimen szaimen added the a11y28checked needed for a11y label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
4. to release Ready to be released and/or waiting for tests to finish a11y28checked needed for a11y accessibility feature: settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enh(aria): changed check color to adhere to 3:1 ratio nextcloud-libraries/nextcloud-vue
5 participants
@susnux @JuliaKirschenheuter @ShGKme @szaimen @emoral435