Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to acknowledge logged errors in security & setup warnings #42383

Open
AndyXheli opened this issue Dec 19, 2023 · 6 comments
Open

Ability to acknowledge logged errors in security & setup warnings #42383

AndyXheli opened this issue Dec 19, 2023 · 6 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: logging feature: settings

Comments

@AndyXheli
Copy link
Contributor

Now with NC 28 once we have error in the logs. Admin can see them under the Security & setup warnings checks. And if server has error is give you a warring that there error like the below pic

It would be nice to have an option to acknowlade the error or warrning so when the setup warnings checks runs again it give you a green check.

image

@AndyXheli AndyXheli added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 19, 2023
@AndyXheli AndyXheli changed the title Acknowledge error Check Box Feature request: Acknowledge error Check Box Dec 19, 2023
@joshtrichards joshtrichards changed the title Feature request: Acknowledge error Check Box Ability to acknowledge logged errors in security & setup warnings Dec 20, 2023
@isdnfan
Copy link

isdnfan commented Dec 22, 2023

another idea regarding this warning would a hyperlink directly navigating to the filtered log view showing the errors.

@franzhartwig
Copy link

The errors in the logfile are not necessarily regarding the setup. So the new hint could be misleading. Perhaps it is a good idea to leave the green tick as before and add an additional hint:
"Additionally, there are xx entries in the logfile. Please, review the logs and resolve the related issues."
"review the logs" could be a link to the logs. I have chosen "entries" instead of "error". There may be some entries with another log level than error.

@paierh
Copy link

paierh commented Jan 22, 2024

If you actually have some activity on your server the chance of a green checkmark is slim to none, because log rotation events are logged as warnings.

@JoshuaPettus
Copy link

JoshuaPettus commented Feb 1, 2024

Most "errors" are benign, incidental, on app developers, or generally nothing really the end user can do anything about.
Is it really a good idea to be hounding system admins on something they can't control? I can't help but feel this new "Good Idea" is just causing admins and troubleshooters unnecessary grief and little to do with system security or stability. If there are no configuration issues can we just let the box be green? The log has always been readily accessible for those that check. Even more so with the new interface.

I have a better idea. How about put only a warning if a system exceeds 5,000 errors in a day or some configurable threshold? That would indicate a constant repeating problem that should probably be looked at and be a lot more useful

@AndyXheli
Copy link
Contributor Author

Personally I liked it the way it was before. Either add on acknowledge or move it back to the way it was.

@plazotronik
Copy link

plazotronik commented Mar 31, 2024

if your log file weighs gigabytes (as we have 3-5 GB) per day, then the check fails with an error. I know for sure that there should have been information about the indexes in the database (after updating - db:add-missing-indexes) and another message about the necessary setting 'maintenance_window_start'. but this information did not appear due to a log scan error. when I deleted the log file 'nextcloud.log' (renamed it), everything immediately worked as expected.
this feature is not a feature, it is a bug. it should be possible to disable such scanning in the file config.php
p.s. There were a lot of free hardware resources. There was no real load
Screenshot_20240331_212822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: logging feature: settings
Projects
None yet
Development

No branches or pull requests

7 participants