Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: settings modal has double scrollbar under some circumstances #42938

Closed
szaimen opened this issue Jan 18, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#5139
Closed

[BITV]: settings modal has double scrollbar under some circumstances #42938

szaimen opened this issue Jan 18, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#5139
Assignees
@susnux
Labels
3. to review Waiting for reviews accessibility design Design, UI, UX, etc.

Comments

@szaimen
Copy link
Contributor

szaimen commented Jan 18, 2024

See
image
@szaimen szaimen added design Design, UI, UX, etc. 0. Needs triage Pending check for reproducibility or if it fits our roadmap accessibility labels Jan 18, 2024
@JuliaKirschenheuter
Copy link
Contributor

not sure that it is an issue - min. viewport height is 1024px and because of this double scrolling is there (was fixed here #36965 (comment)) @ShGKme what do you think?

@ShGKme
Copy link
Contributor

ShGKme commented Jan 18, 2024

I'm almost sure it is a known issue and was fixed somewhere. cc @susnux

@JuliaKirschenheuter JuliaKirschenheuter changed the title settings modal has double scrollbar under some circumstances [BITV]: settings modal has double scrollbar under some circumstances Jan 19, 2024
@susnux
Copy link
Contributor

susnux commented Jan 23, 2024 •
edited

.modal-wrapper .modal-container__content needs to be set to overflow: hidden on NcDialog I think.
It is currently overflow: auto from NcModal. But on NcDialog the dialog content is the scroll area.

@susnux susnux self-assigned this Jan 23, 2024
@susnux susnux added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 25, 2024
@susnux susnux mentioned this issue Jan 25, 2024
Merged
2 tasks
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
3. to review Waiting for reviews accessibility design Design, UI, UX, etc.
Projects
None yet
Milestone
No milestone
4 participants
@susnux @JuliaKirschenheuter @ShGKme @szaimen