Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NC 28.0.2 - Icons in toolbar are black instead of white #43298

Closed
4 of 8 tasks
arnowelzel opened this issue Feb 2, 2024 · 7 comments · Fixed by #43319
Closed
4 of 8 tasks

[Bug]: NC 28.0.2 - Icons in toolbar are black instead of white #43298

arnowelzel opened this issue Feb 2, 2024 · 7 comments · Fixed by #43319
Assignees
Labels

Comments

@arnowelzel
Copy link
Contributor

arnowelzel commented Feb 2, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

All icons in the toolbar are black instead of white.

Steps to reproduce

  1. Upgrade von NC 28.0.1 to 28.0.2
  2. Go to personal settings, Appearanc and accessibility
  3. Selelect "Default background" to get the default background and color
  4. Select "no background" for the background, so only the color is used as background without an image
  5. See icons in the tab bar to turn black instead of staying white - also the small pill below the "active" icon is still white even with the icons in black.

Expected behavior

Icons in the tab bar are white and not black.

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

image

image

@arnowelzel arnowelzel added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 2, 2024
@arnowelzel
Copy link
Contributor Author

arnowelzel commented Feb 2, 2024

As a workaround I added the following custom CSS:

#header {
  --background-image-invert-if-bright: none;
}

I understand the intention of the original filter invented with NC 28.0.2 - but maybe it would be better to have some option for the icon color instead of a filter.

Edit: another "fix" is to make the background color a bit darker in the personal settings, so the filter to change the icon color to black will not trigger. However this will only work individually for a single user account and the "active tab" pill is still wrong (always white even with black app icons). Having the possibility to define a global system wide theme including the icon colors (and the "active tab" pill of course) would be much better.

@ozls
Copy link

ozls commented Feb 3, 2024

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

@arnowelzel
Copy link
Contributor Author

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

Did you try to clear the cache of your browser? In my case the favicons are ok, but I cleared the browser cache after adding the custom CSS

@arnowelzel
Copy link
Contributor Author

I also have this issue. The fix @arnowelzel gave worked for the header icons, but in my case the favicons are also generated as black on blue and are not fixed.

Did you try to clear the cache of your browser? In my case the favicons are ok, but I cleared the browser cache after adding the custom CSS

I stand corrected - indeed some apps have black favicons, but not all of them. I don't understand, how this can happen at all. Even if the favicons are generated, the colors used for that should be based on global preferences and not depending on some app specific rules.

Correct favicons:

Files:
image

Activity:
image

Contacts:
image

Calendar:
image

Deck:
image

Collectives:
image

Tasks:
image

Wrong favicons:

Photos:
image

Notes:
image

@susnux susnux self-assigned this Feb 3, 2024
@susnux susnux added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 3, 2024
@susnux
Copy link
Contributor

susnux commented Feb 3, 2024

The color of the text is based on your background color, it is chosen to have at least 4.5:1 contrast, meaning if you make the background color a bit darker it will be white text.

@ozls
Copy link

ozls commented Feb 4, 2024

Changing the tone of blue solved it for me, thank you @susnux. I don't believe the behavior should have changed like this, but I guess that is another debate.

@regs01
Copy link

regs01 commented May 6, 2024

Just updated to 29.0.0 and it is not fixed. Icons are still black.

There is a filter applies, when shouldn't

.app-menu-main .app-menu-entry img[data-v-62f74e6b] {
  filter: var(--background-image-invert-if-bright);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants