Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup \OCP\Share #4415

Closed
3 tasks
rullzer opened this issue Apr 21, 2017 · 2 comments · Fixed by #44000
Closed
3 tasks

Cleanup \OCP\Share #4415

rullzer opened this issue Apr 21, 2017 · 2 comments · Fixed by #44000
Labels
1. to develop Accepted and waiting to be taken care of feature: sharing technical debt

Comments

@rullzer
Copy link
Member

rullzer commented Apr 21, 2017

Now that the access list is converted as well we should make work of cleaning up the old sharing code properly.

  • Get rid of the registerbackend stuff (we have the factory for that, or we should add functions to the manager to check this)
  • Get rid of all calls to \OCP\Share::
    • mainly in test code
    • maybe to this in small steps for easier review
  • Kill \OC\Share\
@brantje
Copy link
Member

brantje commented Apr 4, 2018

Please notify developers before removing it. I already had a breaking change on a live app.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I suppose this issue is still valid? If not, please close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: sharing technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants