fix(user_ldap): Avoid extra LDAP request when mapping a user for the first time #46114
+132
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $filter = $this->connection->ldapUserFilter; | ||
| $uuidAttr = 'ldapUuidUserAttribute'; | ||
| $uuidOverride = $this->connection->ldapExpertUUIDUserAttr; | ||
| $usernameAttribute = (string)$this->connection->ldapExpertUsernameAttr; |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
…first time Avoids using several LDAP searches to get UUID, display name and internal name, now gets all attributes at the same time. Also avoids extra request to build an unused user object in userExists. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…n mapping new user Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/improve-ldap-group-members-listing-performances
branch
from
4b75668
to
e681d82
Compare
come-nc
added
3. to review
|
Tests are failing indicating problems with attributes case, but I have a hard time understanding how it’s supposed to be. There is this worrying comment: server/apps/user_ldap/lib/Configuration.php Lines 301 to 303 in 3a97dbf It’s not the only one a few of the attributes are not lower cased by the configuration it seems, but as far as I can see all methods getting record from the LDAP do lower case the keys so I’m not sure how it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoids using several LDAP searches to get UUID, display name and
internal name, now gets all attributes at the same time.
Also avoids extra request to build an unused user object in userExists.
TODO
Avoid extra request to fetch the display name by directly caching it. (The display name is fetched by dav to update the calendar entry as soon as the user is mapped).This is too complicated because of internal quirks, keeping an extra request for the display name for now.Checklist