share by email - password email not sent - solved

[moritzthecat]

Steps to reproduce - on netcup webhosting

Nextcloud 12.0.0

1. email config is SMTP - working
2. cron calls cron.php every 15min
3. in share dialog set

• send password by email and
• force password set

2. then share file by email
3. no further settings

Expected behaviour

Tell us what should happen
expect to receive 2 emails

1. email with link to object
2. email with password

Actual behaviour

Tell us what happens instead

1. email with link to object arrives
2. but no email with password

Log shows that both emails should have been sent

Server configuration

Operating system: Linux machinename 2.6.32-642.15.1.el6.x86_64 #1 SMP Fri Feb 24 14:31:22 UTC 2017 x86_64

Web server: Apache (cgi-fcgi)

Database: mysql 5.6.36

PHP version: 5.6.30
Modules loaded: Core, date, ereg, libxml, openssl, pcre, zlib, bcmath, bz2, calendar, ctype, dom, hash, fileinfo, filter, ftp, gettext, SPL, iconv, json, mbstring, session, standard, posix, readline, Reflection, Phar, shmop, SimpleXML, soap, sockets, exif, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlwriter, zip, mysqlnd, cgi-fcgi, curl, gd, imap, mcrypt, mysql, mysqli, PDO, pdo_mysql, PDO_ODBC, xsl, sqlite3, pdo_sqlite, gmp, pcntl, intl, imagick, mhash, ionCube Loader, Zend Guard Loader, Zend OPcache

Nextcloud version: 12.0.0 - 12.0.0.29

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from:

Signing status:

List of activated apps:

App list

``` Enabled: - activity: 2.5.2 - admin_audit: 1.2.0 - bruteforcesettings: 1.0.2 - calendar: 1.5.3 - comments: 1.2.0 - contacts: 1.5.3 - dav: 1.3.0 - deck: 0.2.1 - federatedfilesharing: 1.2.0 - federation: 1.2.0 - files: 1.7.2 - files_downloadactivity: 1.1.1 - files_pdfviewer: 1.1.1 - files_retention: 1.1.2 - files_sharing: 1.4.0 - files_texteditor: 2.4.1 - files_trashbin: 1.2.0 - files_versions: 1.5.0 - files_videoplayer: 1.1.0 - firstrunwizard: 2.1 - gallery: 17.0.0 - issuetemplate: 0.2.1 - logreader: 2.0.0 - lookup_server_connector: 1.0.0 - mozilla_sync: 1 - nextcloud_announcements: 1.1 - notifications: 2.0.0 - oauth2: 1.0.5 - password_policy: 1.2.2 - provisioning_api: 1.2.0 - serverinfo: 1.2.0 - sharebymail: 1.2.0 - survey_client: 1.0.0 - systemtags: 1.2.0 - tasks: 0.9.5 - theming: 1.3.0 - twofactor_backupcodes: 1.1.1 - updatenotification: 1.2.0 - workflowengine: 1.2.0

Disabled:

• encryption
• files_external
• spreedme
• user_external
• user_ldap

</details>

**The content of config/config.php:**
<details>
	<summary>Config report</summary>

{
"instanceid": "12345678",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"SENSITIVE",
"SENSITIVE"
],
"datadirectory": "/var/www/vhosts/hostingaaabbb.aaanetcup.net/cloud-data",
"overwrite.cli.url": "http://www.xxxyyyzzz.sss/cloud",
"dbtype": "mysql",
"version": "12.0.0.29",
"dbname": "123456",
"dbhost": "aa.bb.cc.dd",
"dbport": "",
"dbtableprefix": "xx_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"logtimezone": "UTC",
"installed": true,
"mail_from_address": "name",
"mail_smtpmode": "smtp",
"mail_domain": "SENSITIVE",
"theme": "",
"loglevel": 0,
"maintenance": false,
"updater.secret": "REMOVED SENSITIVE VALUE",
"mail_smtpauthtype": "LOGIN",
"mail_smtpsecure": "ssl",
"mail_smtpauth": 1,
"mail_smtpport": "465",
"mail_smtphost": "aaabbb",
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"mail_smtptimeout": 30,
"activity_expire_days": 180
}

</details>

**Are you using external storage, if yes which one:** files_external is disabled

**Are you using encryption:** no

**Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/...

### Client configuration
**Browser:** Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

**Operating system:**

### Logs
#### Web server error log
<details>
	<summary>Web server error log</summary>
	```
	Insert your webserver log here
	```
</details>

#### Nextcloud log (data/nextcloud.log)
<details>
{"reqId":"AkOPYqZljbxmSmPsXpQo","level":0,"time":"2017-07-08T19:36:28+00:00","remoteAddr":"aaa.bbb.ccc.ddd","user":"name","app":"core","method":"POST","url":"\/cloud\/ocs\/v2.php\/apps\/files_sharing\/api\/v1\/shares?format=json","message":"Sent mail to \"Array\n(\n    [target-email-address] => \n)\n\" with subject \"user\u00bb_aff.BMP\u00ab mit Ihnen geteilt\"","userAgent":"Mozilla\/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko\/20100101 Firefox\/52.0","version":"12.0.0.29"}

{"reqId":"AkOPYqZljbxmSmPsXpQo","level":0,"time":"2017-07-08T19:36:28+00:00","remoteAddr":"aaa.bbb.ccc.ddd","user":"name","app":"core","method":"POST","url":"\/cloud\/ocs\/v2.php\/apps\/files_sharing\/api\/v1\/shares?format=json","message":"Sent mail to \"Array\n(\n    [target-email-address] => \n)\n\" with subject \"Das Passwort zum Zugriff auf u00bb_aff.BMP wurde durch name mit Ihnen geteilt.\"","userAgent":"Mozilla\/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko\/20100101 Firefox\/52.0","version":"12.0.0.29"}
</details>

[moritzthecat]

this could be linked to
#5233
as currently function is broken - at least for this installation - where to patch ?

[moritzthecat]

using pull request of
#5302
to use the email address configured in Nextcloud as sender instead of the users email address does the trick

https://github.com/nextcloud/server/blob/master/apps/sharebymail/lib/ShareByMailProvider.php