Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code integrity check #9375

Open
nickvergessen opened this issue May 3, 2018 · 2 comments
Open

Code integrity check #9375

nickvergessen opened this issue May 3, 2018 · 2 comments

Comments

@nickvergessen
Copy link
Member

There are currently multiple problems with the code integrity check, which should be tackled at some point:

  1. Integrity is only checked after an update, but for everything
  2. Integrity of an app is not checked after an update from the appstore
  3. The code of the app is run (updater) before doing the integrity check.
  4. The integrity check is currently synchronous while running the update (maintenance mode on) but takes a lot of time

Things that should change:

  1. Integrity check should be run before the update (of server and app), so we only run signed code (although for the server this is somewhat unrealistic, because you replaced the files before already, so an attack case can not be covered, only a "borked" upload.
  2. Integrity check should be ran for the specific app when updating via the app store
  3. When updating via console the integrity check should be optional, to allow faster deployment across multiple instances when you use a deployment tool (chef, puppet, git, ...).

cc @MorrisJobke @rullzer

@Mannshoch
Copy link

how could I deactivate integrity check? At moment I get this error on every nextcloud update and I have to remove apps Manually and install them again. At moment I ignore it but It would be nice if I could somehow get ride of this Infobar.

@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

I suppose this issue is still valid? If not, please close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants