Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It'll be nice to have "disable password confirm" option #9474

Closed
zorn-v opened this issue May 14, 2018 · 10 comments
Closed

It'll be nice to have "disable password confirm" option #9474

zorn-v opened this issue May 14, 2018 · 10 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: authentication

Comments

@zorn-v
Copy link
Member

zorn-v commented May 14, 2018

I have app in which users does not know their passwords (nobody knows) - sociallogin. In that app user can be created with generated password.
But sometimes users need to change some options (like email for "forgot password" BTW). In my instance of nexcloud IT IS OK to not ask password for such things.
Why it is compulsorily ?

@MorrisJobke
Copy link
Member

The social login app then needs to "fake disable" this behavior. As of now this is simply a server timestamp and the app then needs to fake this on every request so that the popup is never triggered because nextcloud thinks the login happened just now and doesn't ask for the password again. I would not allow an admin to disable this, but this needs to be done in the app itself.

Please report it in the repo of that app.

@zorn-v
Copy link
Member Author

zorn-v commented May 15, 2018

Please report it in the repo of that app.

I'm author, but thanks for idea.

@MorrisJobke
Copy link
Member

I just noticed that for user_saml we disabled this in the server: #7487

cc @schiessle @rullzer @blizzz Should we add this for the social login as well?

@MorrisJobke MorrisJobke reopened this May 15, 2018
@MorrisJobke MorrisJobke added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: authentication labels May 15, 2018
@blizzz
Copy link
Member

blizzz commented May 15, 2018

As commented there already, i don't like that the backend name is hard coded. We should introduce an interface for this, and than any backend can use it.

@zorn-v
Copy link
Member Author

zorn-v commented May 16, 2018

I implemented this option in personal settings in my app. But I think it should be in core.

@rullzer
Copy link
Member

rullzer commented Jun 7, 2018

I agree with @blizzz here. Now that we have the fancy new interfaces we could actually check this.

@zorn-v
Copy link
Member Author

zorn-v commented Jun 7, 2018

Hardcoded check of hardcoded interfaces.
What I should do if I don't need implement that interface (example - sociallogin app) ?
I mean no need to implement user backend.

@rullzer
Copy link
Member

rullzer commented Jun 7, 2018

@zorn-v we improved the user backend handling (see https://github.com/nextcloud/server/tree/master/lib/public/User/Backend)

Probably if we'd add a new interface here. Which doesn't have any functions to implement. But it can tell the server 'ok this backend doesn't support this' then we can take action accordingly.

@zorn-v
Copy link
Member Author

zorn-v commented Jun 7, 2018

Well, what should I do while using standard DB user manager and no need of confirmation ?
Is below line of code HARDER then you preffer ?
https://github.com/zorn-v/nextcloud-social-login/blob/master/lib/AppInfo/Application.php#L38

@rullzer
Copy link
Member

rullzer commented Jun 7, 2018

Well that should work as well I guess... 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: authentication
Projects
None yet
Development

No branches or pull requests

6 participants