Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stable27] fix(LeftSidebar): Disable blur event in order to click on a conversation #10781

Merged
merged 2 commits into from Oct 26, 2023
Merged

[Stable27] fix(LeftSidebar): Disable blur event in order to click on a conversation #10781

merged 2 commits into from Oct 26, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Oct 26, 2023 •
edited

Backport #10737
Changed ref to "container"

@DorraJaouad
Add key prop to NclistItem to re-render conversation with the appropr…
16e507a 
…iate class

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💘 Next Patch (27) milestone Oct 26, 2023
DorraJaouad
DorraJaouad commented Oct 26, 2023
View reviewed changes
Copy link
Contributor Author

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

Antreesy
Antreesy reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use ref container? Scroller is only for virtual scroller, as I see

@DorraJaouad
fix(LeftSidebar): disable the blur event of the search box when click…
3a4d174 
…ing on a conversation.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@nickvergessen nickvergessen mentioned this pull request Oct 26, 2023
Merged
@DorraJaouad DorraJaouad merged commit 84aee49 into stable27 Oct 26, 2023
22 checks passed
@DorraJaouad DorraJaouad deleted the backport/10737/stable27 branch October 26, 2023 20:07
@nickvergessen nickvergessen mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release bug feature: frontend 🖌️ "Web UI" client feature: search 🔎
Projects
None yet
Milestone
v17.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DorraJaouad @Antreesy