fix(reactions): Don't break mobile clients when the reactions list is… #10832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: api 🛠️
nickvergessen
force-pushed
the
bugfix/noid/empty-reactions-list
branch
from
e69674d
to
441087a
Compare
nickvergessen
commented
Nov 3, 2023
| protected function assertEmptyArrayIsNotAListButADictionary(?TableNode $formData, string $content) { | ||
| if (!$formData instanceof TableNode || empty($formData->getHash())) { | ||
| $data = json_decode($content); | ||
| Assert::assertIsNotArray($data->ocs->data, 'Response ocs.data should be an "object" to represent a JSON dictionary, not a list-array'); |
There was a problem hiding this comment.
Before the patch in lib this throws:
Then user "participant1" retrieve reactions "👍" of message "Message 1" in room "room" with 200 # FeatureContext::userRetrieveReactionsOfMessageInRoomWith()
| actorType | actorId | actorDisplayName | reaction |
Data should be an "object" to represent a JSON dictionary, not a list
Failed asserting that Array &0 () is not of type "array".
… empty Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/empty-reactions-list
branch
from
441087a
to
96cf85e
Compare
|
/backport to stable27 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… empty
☑️ Resolves
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required