Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(API): Require recording consent compatible version of clients #10969

Merged

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Only required when recording consent is not Off (enabled or optional)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: recordings ⏺️ Including the recording server labels Nov 22, 2023
@nickvergessen nickvergessen added this to the 💙 Next Beta (28) milestone Nov 22, 2023
@nickvergessen nickvergessen self-assigned this Nov 22, 2023
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Noticed that the regex for the desktop client silently differs:

+  '/^Mozilla\/5\.0 \((?!Android|iOS)[A-Za-z ]+\) Nextcloud\-Talk v([^ ]*).*$/';
-  '/^Mozilla\/5\.0 \((?!Android|iOS)[A-Za-z ]+\) Nextcloud-Talk v([^ ]*).*$/';

But that shouldn't be a problem, as the - doesn't need to be escaped anyway.

@ShGKme
Copy link
Contributor

ShGKme commented Nov 22, 2023

But that shouldn't be a problem, as the - doesn't need to be escaped anyway.

Yep, - is a special character only in a symbol class []

@nickvergessen nickvergessen merged commit 202a83f into main Nov 22, 2023
48 checks passed
@nickvergessen nickvergessen deleted the bugfix/10726/require-recording-consent-compatible-clients branch November 22, 2023 11:25
This was referenced Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: recordings ⏺️ Including the recording server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump required minimum version on connection to matching clients/desktop
3 participants