Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): use provided from openapi message parameters models #11807

Merged
merged 5 commits into from Mar 15, 2024
Merged

fix(openapi): use provided from openapi message parameters models #11807

merged 5 commits into from Mar 15, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 14, 2024 •
edited

☑️ Resolves

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 14, 2024
@Antreesy Antreesy self-assigned this Mar 14, 2024
@Antreesy Antreesy force-pushed the followup/11802/message-parameters-ts branch from 2fb4ed5 to de9a197 Compare March 14, 2024 18:38
DorraJaouad
DorraJaouad reviewed Mar 14, 2024
View reviewed changes
src/types/index.ts Outdated Show resolved Hide resolved
src/types/index.ts Show resolved Hide resolved
DorraJaouad
DorraJaouad reviewed Mar 14, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Antreesy
fix(openapi): use provided from openapi message parameters models
5c98d30 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the followup/11802/message-parameters-ts branch from de9a197 to 2c8d108 Compare March 15, 2024 09:18
@Antreesy
fix(typescript): migrate messagesService to ts
0caa8f2 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(typescript): move unrelated methods to appropriate services
38224b7 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(typescript): move related methods to messageService
74ad672 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(typescript): migrate reactionsService to ts
dda2d2b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the followup/11802/message-parameters-ts branch from 2c8d108 to dda2d2b Compare March 15, 2024 09:23
DorraJaouad
DorraJaouad approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@Antreesy Antreesy merged commit 7736524 into main Mar 15, 2024
46 checks passed
@Antreesy Antreesy deleted the followup/11802/message-parameters-ts branch March 15, 2024 13:47
@nickvergessen nickvergessen mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Antreesy @DorraJaouad