Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups with special Character can not be addressed #11935

Open
xbluemonkx opened this issue Mar 26, 2024 · 2 comments
Open

Groups with special Character can not be addressed #11935

xbluemonkx opened this issue Mar 26, 2024 · 2 comments

Comments

@xbluemonkx
Copy link

xbluemonkx commented Mar 26, 2024

Steps to reproduce

  1. Create a user group, that has a Special Charakter in it (Umlaute: äöü) (eg: "Bälle" - german word for "Balls")
  2. Add this group to a chat
  3. reference the group in a message using @group (@Bälle)

Expected behaviour

it should work like it works with users or groups without special character. The group should be converted into that visual icon of the group.

Actual behaviour

Message looks like this: "Hello Friends of @"group/Bälle" can someone please call me?"

Talk app

Talk 18.0.5
Nextcloud 28.0.3
Firefox

@nickvergessen
Copy link
Member

Yeah the server code only supports a-zA-Z0-9 at the moment for the group IDs:
https://github.com/nextcloud/server/blob/e5b0c06b2449d9015ed1ce5d0fd027836babc939/lib/private/Comments/Comment.php#L223

However you could create a group Baelle with the displayname Bälle:

occ  group:add --help
Description:
  Add a group

Usage:
  group:add [options] [--] <groupid>

Arguments:
  groupid                          Group id

Options:
      --display-name=DISPLAY-NAME  Group name used in the web UI (can contain any characters)

At least on CLI the option is easily accessible.

In the web you would need to create the group as Baelle and then rename it afterwards.

@xbluemonkx
Copy link
Author

Hi @nickvergessen,

thanks for the input. this bug is anoying, but not critical. therefore we will just live with it until there is a fix in the server code.

but the workaround looks good and I am glad you wrote it down. maybe someone else will use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants