Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While in a call the chat doesn't keep scrolling to the end #7690

Closed
nickvergessen opened this issue Aug 9, 2022 · 4 comments · Fixed by #8761
Closed

While in a call the chat doesn't keep scrolling to the end #7690

nickvergessen opened this issue Aug 9, 2022 · 4 comments · Fixed by #8761
Assignees

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Aug 9, 2022

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Join a call
  2. Have the chat open
  3. Move the window to a second screen to take notes in the other part
  4. Colleagues post messages

Expected behaviour

Chat should stay scrolled to the bottom and always show the last messages

Actual behaviour

First message is like 80% visible and you can scroll to the bottom.
If you don't new messages are not shown

Talk app

Talk app version: 14+

@nickvergessen
Copy link
Member Author

So we don't scroll when the window is not focused, which is okay when the window is not visible, but if you do a recording it is rather annoying.

@SystemKeeper
Copy link
Contributor

Maybe it would also make sense to use the page visibility api here... I regularly have a chat open on the second screen and it won't scroll because the window is not focused anymore 😕
Also in a call it totally makes sense 👍

@nickvergessen
Copy link
Member Author

I fear that is exactly what we are using:

document.addEventListener('visibilitychange', this.changeWindowVisibility)

@SystemKeeper
Copy link
Contributor

The problem is this I guess:

if (this.isWindowVisible && document.hasFocus()) {

We still check for focus, not the visibility: https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants