Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user setting for toggle typing privacy #9455

Merged
merged 6 commits into from May 5, 2023

Conversation

vitormattos
Copy link
Contributor

API side of #9248 to implement an user setting to toggle typing privacy

🏁 Checklist

@vitormattos vitormattos added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants php labels May 4, 2023
@vitormattos vitormattos added this to the 17.0.0-beta.1 milestone May 4, 2023
@vitormattos vitormattos self-assigned this May 4, 2023
lib/Config.php Outdated Show resolved Hide resolved
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also search if the preference name, capability name or config function is used anywhere else

@vitormattos vitormattos force-pushed the feature/user-setting-for-typing-privacy branch from 1cdc444 to 099379b Compare May 4, 2023 20:13
docs/constants.md Outdated Show resolved Hide resolved
lib/Controller/AvatarController.php Outdated Show resolved Hide resolved
lib/Controller/SettingsController.php Outdated Show resolved Hide resolved
lib/TInitialState.php Outdated Show resolved Hide resolved
tests/integration/features/chat-2/typing-privacy.feature Outdated Show resolved Hide resolved
tests/integration/features/chat-2/typing-privacy.feature Outdated Show resolved Hide resolved
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos force-pushed the feature/user-setting-for-typing-privacy branch from 099379b to 7e9a768 Compare May 5, 2023 08:19
Signed-off-by: Vitor Mattos <vitor@php.rio>
@SystemKeeper
Copy link
Contributor

Fine by me.
CC: @danxuliu About the capability name, so you're aware

@nickvergessen nickvergessen merged commit aebe7c0 into master May 5, 2023
29 checks passed
@nickvergessen nickvergessen deleted the feature/user-setting-for-typing-privacy branch May 5, 2023 11:47
@nickvergessen nickvergessen mentioned this pull request May 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants