Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/9446/add-empty-call-view-to-viewer-overlay #9460

Merged
merged 1 commit into from May 9, 2023
Merged

fix/9446/add-empty-call-view-to-viewer-overlay #9460

merged 1 commit into from May 9, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 4, 2023 •
edited

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Gif with the smallest size

EmptyCallViewOnOverlay

Fullscreen on light theme

image

🚧 Tasks

  • Add EmptyCallView to ViewerOverlayCallView

🏁 Checklist

@ShGKme ShGKme self-assigned this May 5, 2023
@ShGKme ShGKme force-pushed the fix/9446/add-empty-call-view-to-viewer-overlay branch 3 times, most recently from 6b8f2e8 to 1138541 Compare May 5, 2023 14:00
@ShGKme
Copy link
Contributor Author

ShGKme commented May 5, 2023

Tested on web and desktop with light and dark theme on small and large screen

@ShGKme ShGKme marked this pull request as ready for review May 5, 2023 14:07
@Antreesy
Copy link
Contributor

Antreesy commented May 5, 2023 •
edited

Not visible for me at public conversations, until any user is connected. Private conversations work fine (Ubuntu, Chrome)

overlay.mp4

P.S. Now it works. and I can not reproduce it again 🤔

Antreesy
Antreesy approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is perfect from code perspective 🦭
Tested on web client

@ShGKme
Copy link
Contributor Author

ShGKme commented May 5, 2023 •
edited

P.S. Now it works. and I can not reproduce it again 🤔

Maybe old cache?

However, I didn't test public conversations. I'll try.

@nickvergessen nickvergessen added this to the 💙 Next Beta (27) milestone May 8, 2023
@nickvergessen
Copy link
Member

So merge?

This was referenced May 9, 2023
Merged
Closed
@ShGKme
fix(ViewerOverlay): add EmptyCallView
10d85de 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/9446/add-empty-call-view-to-viewer-overlay branch from 1138541 to 10d85de Compare May 9, 2023 08:16
@ShGKme
Copy link
Contributor Author

ShGKme commented May 9, 2023

Rebased onto master and fixed indents, no other changes

@nickvergessen nickvergessen mentioned this pull request May 9, 2023
Merged
2 tasks
@nickvergessen nickvergessen merged commit 68f72b6 into master May 9, 2023
19 checks passed
@nickvergessen nickvergessen deleted the fix/9446/add-empty-call-view-to-viewer-overlay branch May 9, 2023 10:48
@nickvergessen nickvergessen mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Antreesy approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@ShGKme ShGKme

Labels
4. to release bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v17.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Show an empty call view in the viewer overlay when there is only 1 participant or connection
3 participants
@ShGKme @Antreesy @nickvergessen