New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clearing of guests #9517
Fix clearing of guests #9517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleaning of guests is triggered if the guests have default permissions or custom permissions, but all removed. However, the guests are not cleaned if they do not have default permissions, including custom permissions but all removed.
Other than that, tested and works 👍
Oracle, MySQL and SQLite return ints as strings from the DB Signed-off-by: Joas Schilling <coding@schilljs.com>
…moved Signed-off-by: Joas Schilling <coding@schilljs.com>
e44ea7d
to
80b96cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Out of curiosity, if all the permissions are removed for a guest, why is that guest cleared while guests with any other custom permissions are kept?
My idea/thoughts were the following:
|
☑️ Resolves
🏁 Checklist
docs/
has been updated or is not required