Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login screen #31

Closed
tobiasKaminsky opened this issue Dec 15, 2017 · 4 comments
Closed

Login screen #31

tobiasKaminsky opened this issue Dec 15, 2017 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Dec 15, 2017

The input field is a little darker, which in my opinion, does not look very good.
In general it looks very empty, maybe add also some infos, like on nc app?
Maybe also remove "talk" in "nextcloud talk server" as it can lead to the impression that there is a special talk server instead of the regular nextcloud server (of course with talk app enabled)
@jancborchardt

2017-12-15-151350 2017-12-15-151426

@mario
Copy link
Contributor

mario commented Dec 15, 2017

a) I need to check what's up with the logo
b) title was already changed to "Nextcloud server address"
c) There will be a proceed button under this all
d) IHMO, the input box looks nice - it's TextField Box according to Material guidelines

@jancborchardt
Copy link
Member

jancborchardt commented Dec 15, 2017

Fully agree with @tobiasKaminsky’s points, as I also noted via email @mario ;)

  • Can confirm the weird logo. Looks like lossy SVG compression
  • The dark background of the input box is unnecessary, the white line already is enough.
  • The arrow is good as a confirm button. Either way we do it, it should be consistent across both apps please.
  • We can put the same notice we have in the Files app there too. @jospoortvliet maybe a filter on the providers page as to which provider has the Talk app enabled?

Also – it would be really nice if we would not have this issue at all and just Take server address & credentials from main Nextcloud app #14 ;)

@jancborchardt jancborchardt added the bug Something isn't working label Dec 15, 2017
@mario
Copy link
Contributor

mario commented Dec 15, 2017

Like I mentioned, I don't necessarily agree, but one cannot win all the fights so ... :)

@jancborchardt
Copy link
Member

As said, we designed the Files app view for a reason like that and I'm not fond of going through the same design discussion process again when we already know how to do it. ;)

@mario mario self-assigned this Dec 17, 2017
@mario mario closed this as completed Dec 18, 2017
@mario mario added this to the v0.1.2 milestone Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants