[BUG] Cannot add Webauthn Devices

[bones1014]

Describe the bug
When trying to add a Webauthn Device the button just flashes briefly but won't start adding a device.

To Reproduce
Steps to reproduce the behavior:

1. Go to Security under Personal
2. Click on Add Webauthn Device
3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (feel free to add relevant information)

• Twofactor_Webauthn Version: 0.2.9
• Nextcloud Version: snap 20.0.9
• PHP Version: 7.4.15
• Database with Version: mysql 5.7.34
• Browser with Version: Opera 76.0.4017.94 and chrome 90.0.4430.93 (Official Build) (64-bit)
• OS: Windows 10 build 19042.964

Webauthn Devices
Please list here your webauthn devices, which relate to the issue, eg:

• Yubikey 5 NFC
• Windows Hello

Nextcloud error log
Please attach the nextcloud error log, if applicable

Browser error log
Please attach the error from the developer console of the browser, if applicable

Additional context

Error	index	Exception: Argument 1 passed to OC\Core\Controller\WebAuthnController::finishAuthentication() must be of the type string, null given, called in /snap/nextcloud/27434/htdocs/lib/private/AppFramework/Http/Dispatcher.php on line 169

[michib]

Hi @bones1014,

i'm not able to reproduce the issue. It works for me. But from the logmessage, it looks like you are trying to setup a first factor authentication with your yubikey? Thats not related to this twofactor provider, the firstfactor authentication is provided by nextcloud itself.

If it happens on setting up a key for this twofactor provider, could you provide more information how to reproduce the issue?

[isdnfan]

Just tested successfully using latest docker NC 21.0.2 (version from 04.06.2021) and Two-Factor Webauthn 0.2.10

[bones1014]

I'll give it another try since my snap updated recently. Thanks for looking!

[bones1014]

There hasn't been any change to the way the app is behaving. I've removed and reinstalled the app and it still doesn't allow me to add a webaunth device. I've tried in different browsers and they are all the same.

[michib]

Is it still the same error Message?

[bones1014]

It doesn't give any error message. It just doesn't allow me to add a device. It just flashes to the graphic like it's going to add one and then just goes back to the add button.

[michib]

Could you provide a screenshot of what you are trying to do?

[bones1014]

That button just flashes to "please plug in...." It's too fast to read. The box to add a device doesn't appear.

[michib]

And there is no further error entry in the nextcloud log?
Could you check the console of your browser? You can open it with pressing F12. Can you check if there is some error message (or anything other) logged?

[bones1014]

New Text Document (3).txt

[michib]

That are the contents of the console? To be honest, i doubt that. That's the sourcecode of the page

[michib]

Please provide a screenshot of what you just copied. Maybe i can point you to the right direction afterwards.

[bones1014]

When I have the console open and then click the Add Webauthn Device button I get this:

[michib]

Do you have you installation provided by https?

[bones1014]

I thought I did. I was primarily accessing it on my local network and I guess it didn't like the HTTPS. I just went through the web address with is running HTTPS and has no problem and it's working. huh, I didn't think about that. Thanks for the guidance.

[michib]

Ah alright. Thanks for the feedback. I will add some error handling for this. Webauthn only works through https by spec, the browsers restrict http connections.

[Bondarz]

Same here. I used Nextcloud Storageshare by Hetzner. Windows 10, Firefox 93, YubiKey5.
U2F works without a probem. No chance to add WebAuthn after enter my FIDO2 PIN. YubiKey cannot be saved.

[michib]

Please! Provide some more information.
Is there anything in the log of nextcloud or the console of your browser?

[Bondarz]

Problem also exists with Mastodon, by the way:
mastodon/mastodon#16694 (comment)

I was able to save the keys with the Brave Browser, then the login also works under Firefox. Only the registration of a key does not work with Firefox.

Is this correct? ;)

[Bondarz]

Firefox:

[michib]

Are you trying to setup a 2FA or Passwordless Authentication?

[Bondarz]

Brave Browser V1.31.87
Nextcloud: Storage Share 22.1.1

With Brave i was able to add my FIDO2 Key, hope this could help:

brave.txt

[Bondarz]

Are you trying to setup a 2FA or Passwordless Authentication?

Username/Password with U2F YubiKey
Than i tried Username with Webauthn/FIDO2 YubiKey

[michib]

I dont understand your answer. So are you trying to setup 2FA or Passwordless? U2F is not in the scope of this provider.

[michib]

From your screenshot it seems you are trying to setup Passwordless Authentication. This is not in the scope of this 2FA Provider. If its an issue of this Provider please open a new Bug. Your problem does not seem to be related to this issue.

[Muzosh]

Hello @michib,

I'm having a same issue as the original author of this issue: after clicking on the button a small loading circle shows up for a split second and then disappears and nothing happens.

Immediately after clicking on the button there is a message "starting webauthn registration" and it is followed by this error:

It is logged right here:

BTW, I did not even tried to register any webauthn device, I just freshly installed this provider and tried to click on that button.
Nextcloud version: 21.0.2 and tried also with 21.0.5

[michib]

@Muzosh i think the error message indicates, that you should check your nextcloud setup. It has to run on a https connection. But i don't know what this error message exactly means. You can try to install the new released version 0.2.12 and provide the logs of the browser console and the server logs here.

[michib]

@Muzosh could you retry with version 0.2.13 and post the console entries of your browsers? Please remove any sensitive data before!

[Muzosh]

@michib Here is the result of clicking the button after updating to 0.2.13:

As you have said, I'm running nextcloud on my own testing server with self-signed certificate. It is https connection but with invalid certificate that I had to allow when first connected to this server. So my problem might be in wrong configuration of the server.

Thanks anyway, I wanted to test your app because I'm creating a different two-factor as well.

[michib]

Yes localhost does not work in every browser afaik. For my development testing i am using a local domain like "cloud.net.local". Browsers are happy with it :-)
In this case i am closing the issue, please reopen or open another bug if it turns out that the issue is part of the provider and not of the server configuration.