Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Override hardcoded save button width #1657

Merged
merged 1 commit into from
May 11, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 11, 2023

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #1656

@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working javascript Javascript related ticket labels May 11, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.1 milestone May 11, 2023
@artonge
Copy link
Contributor

artonge commented May 11, 2023

/compile amend /

The save button wrapper have a fixed width: https://github.com/scaleflex/filerobot-image-editor/blob/775f3cbc827755fda0f067265719df0787b355c8/packages/react-filerobot-image-editor/src/components/Topbar/SaveButton.jsx#L31

This PR override this hardcoded value to give it more flexibility.

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge marked this pull request as ready for review May 11, 2023 19:47
@artonge artonge added the 3. to review Waiting for reviews label May 11, 2023
@artonge artonge merged commit 82a547e into stable26 May 11, 2023
27 checks passed
@artonge artonge deleted the backport/1656/stable26 branch May 11, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant