Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ForumChannel and Thread returning wrong ForumTags #1021

Merged
merged 5 commits into from Apr 1, 2023
Merged

fix: ForumChannel and Thread returning wrong ForumTags #1021

merged 5 commits into from Apr 1, 2023

Conversation

Fenix5fire
Copy link
Contributor

@Fenix5fire Fenix5fire commented Mar 26, 2023 •
edited

Summary

Fixed ForumChannel.available_tags only returned last tag by wrong id: used wrong dict to get id
Fixed Thread.applied_tags and Thread.applied_tag_ids returned empty list: used non-existent key in getting tags data from payload
ForumTag id is no longer optional when getting from payload

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Fenix5fire Fenix5fire mentioned this pull request Mar 26, 2023
Closed
3 tasks
Skelmis
Skelmis approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but appears to line up with docs + was in the help thread for this so probs fine by me

@EmreTech EmreTech changed the title Fix: ForumChannel and Thread returning wrong ForumTags fix: ForumChannel and Thread returning wrong ForumTags Mar 30, 2023
@EmreTech EmreTech added t: bug Type: bug - something isn't working p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews labels Mar 30, 2023
@EmreTech EmreTech linked an issue Mar 30, 2023 that may be closed by this pull request
ForumChannel and Thread returning wrong ForumTags #1019
Closed
3 tasks
EmreTech
EmreTech approved these changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@EmreTech EmreTech merged commit abbd076 into nextcord:master Apr 1, 2023
10 checks passed
@EmreTech EmreTech removed the s: awaiting review Status: the issue or PR is awaiting reviews label Apr 1, 2023
@TeRacksito TeRacksito mentioned this pull request Apr 7, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

@EmreTech EmreTech EmreTech approved these changes

Assignees
No one assigned
Labels
p: high Priority: high - should be worked on as soon as reasonable t: bug Type: bug - something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForumChannel and Thread returning wrong ForumTags
3 participants
@Fenix5fire @Skelmis @EmreTech