Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add guild preview #1033

Merged
merged 29 commits into from Jul 1, 2023
Merged

feat: add guild preview #1033

merged 29 commits into from Jul 1, 2023

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Apr 7, 2023 •
edited

Summary

This implements the GuildPreview function, along with some related functions for Client, and HTTPClient.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

spifory and others added 13 commits April 7, 2023 09:26
Skelmis
Skelmis requested changes Apr 9, 2023
View reviewed changes
nextcord/guild_preview.py Outdated Show resolved Hide resolved
nextcord/guild_preview.py Outdated Show resolved Hide resolved
nextcord/guild_preview.py Outdated Show resolved Hide resolved
@spifory spifory requested a review from Skelmis April 9, 2023 13:14
Skelmis
Skelmis requested changes Apr 9, 2023
View reviewed changes
nextcord/guild_preview.py Outdated Show resolved Hide resolved
nextcord/guild_preview.py Outdated Show resolved Hide resolved
teaishealthy
teaishealthy requested changes Apr 9, 2023
View reviewed changes
Copy link
Collaborator

@teaishealthy teaishealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested but other than the versionadded lgtm :)

nextcord/guild_preview.py Show resolved Hide resolved
@Skelmis Skelmis requested a review from ooliver1 April 27, 2023 08:49
@EmreTech EmreTech added p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels Jun 15, 2023
EmreTech
EmreTech requested changes Jun 15, 2023
View reviewed changes
nextcord/guild_preview.py Show resolved Hide resolved
spifory and others added 2 commits June 15, 2023 09:43
@spifory @EmreTech
docs: add versionadded to class
af2dbb8 
Co-authored-by: Emre Terzioglu <50607143+EmreTech@users.noreply.github.com>
@spifory
docs: remove duplicate versionadded
5b9c784
@spifory spifory requested a review from EmreTech June 15, 2023 07:44
EmreTech
EmreTech requested changes Jun 16, 2023
View reviewed changes
nextcord/guild_preview.py Show resolved Hide resolved
nextcord/client.py Show resolved Hide resolved
nextcord/guild_preview.py Outdated Show resolved Hide resolved
@spifory spifory requested a review from EmreTech June 16, 2023 18:55
EmreTech
EmreTech requested changes Jun 17, 2023
View reviewed changes
nextcord/client.py Show resolved Hide resolved
@spifory spifory requested a review from EmreTech June 17, 2023 09:45
EmreTech
EmreTech approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@EmreTech EmreTech merged commit 084c013 into nextcord:master Jul 1, 2023
17 checks passed
@spifory spifory deleted the feat/add-guild-preview branch July 1, 2023 18:53
@EmreTech EmreTech removed the s: awaiting review Status: the issue or PR is awaiting reviews label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

@EmreTech EmreTech EmreTech approved these changes

@teaishealthy teaishealthy teaishealthy approved these changes

@ooliver1 ooliver1 Awaiting requested review from ooliver1

Assignees
No one assigned
Labels
p: low Priority: low - not important to be worked on t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spifory @ooliver1 @Skelmis @EmreTech @teaishealthy