Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add MemberFlags and relevant fields #1042

Merged
merged 8 commits into from Sep 20, 2023

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Apr 17, 2023

Summary

Relevant link to API Docs:

This PR adds support for getting a member's flags via the matching attributes.

I have not tested this but.. most of the code is from my PR to discord.py - Rapptz/discord.py#9204 which was fully tested.

Adds the following:

  • Classes:

    • MemberFlags
  • Attributes to nextcord.Member:

    • _flags
    • flags (property)
  • Kwargs to nextcord.Member.edit:

    • flags
    • bypass_verification
  • Fields to PartialMember (type):

    • flags
  • Possible attrs for on_member_update (docs):

    • flags

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@ooliver1 ooliver1 changed the title feat(flags): Add MemberFlags and relevant fields feat(flags): add MemberFlags and relevant fields Apr 17, 2023
@ooliver1 ooliver1 added p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API 2.5 The issue/PR should go for the 2.5 release labels Apr 17, 2023
@ooliver1 ooliver1 added this to the 2.5 milestone Apr 17, 2023
nextcord/flags.py Outdated Show resolved Hide resolved
Copy link
Member

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental approval yet again

@Soheab Soheab requested a review from ooliver1 April 28, 2023 14:23
@ooliver1 ooliver1 removed this from the 2.5 milestone Jun 13, 2023
@ooliver1 ooliver1 added 2.6 The issue/PR should go for the 2.6 release and removed 2.5 The issue/PR should go for the 2.5 release labels Jun 13, 2023
@ooliver1 ooliver1 added this to the 2.6 milestone Jun 13, 2023
nextcord/flags.py Outdated Show resolved Hide resolved
nextcord/member.py Show resolved Hide resolved
nextcord/flags.py Outdated Show resolved Hide resolved
nextcord/member.py Outdated Show resolved Hide resolved
nextcord/member.py Outdated Show resolved Hide resolved
nextcord/member.py Outdated Show resolved Hide resolved
nextcord/member.py Outdated Show resolved Hide resolved
nextcord/member.py Show resolved Hide resolved
nextcord/flags.py Outdated Show resolved Hide resolved
Co-authored-by: Oliver Wilkes <oliverwilkes2006@icloud.com>
@ooliver1 ooliver1 enabled auto-merge (squash) September 19, 2023 22:44
@ooliver1 ooliver1 merged commit 8ab9135 into nextcord:master Sep 20, 2023
10 checks passed
@ooliver1 ooliver1 removed the s: awaiting review Status: the issue or PR is awaiting reviews label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.6 The issue/PR should go for the 2.6 release p: high Priority: high - should be worked on as soon as reasonable t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
No open projects
Status: In Cycle
Development

Successfully merging this pull request may close these issues.

None yet

3 participants