fix(app-cmds): unfocused options not getting passed in autocomplete callback #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1045
Bug:
from_autocomplete_callback
is not getting called andautocomplete_options
is not getting populated whenautocomplete_callback
is supplied to a SlashOption rather than using the decorator. This causes other options from the command to be inaccessible from the autocomplete callback method (see linked issue).Fix:
Replaces
iscoroutinefunction
check inSlashCommandOption
with a call toself.from_autocomplete_callback(self.autocomplete_callback)
which includes theiscoroutinefunction
check and also populates theautocomplete_options
field to have the other options in the command so they can be accessed later when the callback is called (seefrom_autocomplete_callback
).Checklist
task pyright
and fixed the relevant issues.