Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add attachment flags #1088

Merged
merged 10 commits into from Aug 12, 2023

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Jul 10, 2023

Summary

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@spifory spifory added 2.6 The issue/PR should go for the 2.6 release p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. t: api coverage Type: api coverage - this adds code to cover the discord API t: enhancement Type: enhancement - new feature or request labels Jul 10, 2023
@spifory spifory added this to the 2.6 milestone Jul 10, 2023
@spifory
Copy link
Collaborator Author

spifory commented Jul 10, 2023

While the flags from discord/discord-api-docs#6272 (comment) need to be added too, I'd like for them to be in the actual documentation.

nextcord/types/message.py Outdated Show resolved Hide resolved
nextcord/message.py Outdated Show resolved Hide resolved
@ooliver1
Copy link
Member

Draft as this is waiting on a docs PR.

@ooliver1 ooliver1 marked this pull request as draft July 11, 2023 08:04
@ooliver1 ooliver1 added p: medium Priority: medium - should be worked on in the near future and removed p: high Priority: high - should be worked on as soon as reasonable t: enhancement Type: enhancement - new feature or request 2.6 The issue/PR should go for the 2.6 release labels Jul 11, 2023
@ooliver1 ooliver1 removed this from the 2.6 milestone Jul 11, 2023
@spifory spifory requested a review from ooliver1 July 13, 2023 08:49
@EmreTech
Copy link
Collaborator

Docs PR has been merged.

@EmreTech EmreTech marked this pull request as ready for review July 13, 2023 17:43
@EmreTech EmreTech removed the s: waiting for discord status: the issue requires changes to the documentation or behaviour before it can be completed. label Jul 13, 2023
@spifory spifory added the 2.6 The issue/PR should go for the 2.6 release label Jul 18, 2023
nextcord/flags.py Show resolved Hide resolved
nextcord/flags.py Outdated Show resolved Hide resolved
Copy link
Member

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
image

@bot.message_command()
async def flags(inter: Interaction, message: Message):
    await inter.send(
        ", ".join(f"{k}: {v}" for k, v in list(message.attachments[0].flags))
        if message.attachments
        else "no attachments"
    )

@EmreTech EmreTech merged commit a66b310 into nextcord:master Aug 12, 2023
10 checks passed
@EmreTech EmreTech removed the s: awaiting review Status: the issue or PR is awaiting reviews label Aug 12, 2023
@spifory spifory deleted the spifory/feat/add-attachment-flags branch August 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.6 The issue/PR should go for the 2.6 release p: medium Priority: medium - should be worked on in the near future t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants