New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add attachment flags #1088
Merged
EmreTech
merged 10 commits into
nextcord:master
from
spifory:spifory/feat/add-attachment-flags
Aug 12, 2023
Merged
feat: add attachment flags #1088
EmreTech
merged 10 commits into
nextcord:master
from
spifory:spifory/feat/add-attachment-flags
Aug 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spifory
added
2.6
The issue/PR should go for the 2.6 release
p: high
Priority: high - should be worked on as soon as reasonable
s: awaiting review
Status: the issue or PR is awaiting reviews
s: waiting for discord
status: the issue requires changes to the documentation or behaviour before it can be completed.
t: api coverage
Type: api coverage - this adds code to cover the discord API
t: enhancement
Type: enhancement - new feature or request
labels
Jul 10, 2023
While the flags from discord/discord-api-docs#6272 (comment) need to be added too, I'd like for them to be in the actual documentation. |
ooliver1
requested changes
Jul 11, 2023
Draft as this is waiting on a docs PR. |
ooliver1
added
p: medium
Priority: medium - should be worked on in the near future
and removed
p: high
Priority: high - should be worked on as soon as reasonable
t: enhancement
Type: enhancement - new feature or request
2.6
The issue/PR should go for the 2.6 release
labels
Jul 11, 2023
ooliver1
reviewed
Jul 12, 2023
Docs PR has been merged. |
EmreTech
removed
the
s: waiting for discord
status: the issue requires changes to the documentation or behaviour before it can be completed.
label
Jul 13, 2023
EmreTech
approved these changes
Aug 3, 2023
teaishealthy
approved these changes
Aug 3, 2023
ooliver1
requested changes
Aug 7, 2023
ooliver1
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmreTech
removed
the
s: awaiting review
Status: the issue or PR is awaiting reviews
label
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.6
The issue/PR should go for the 2.6 release
p: medium
Priority: medium - should be worked on in the near future
t: api coverage
Type: api coverage - this adds code to cover the discord API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a Code Change
task pyright
and fixed the relevant issues.