Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Commands Documentation #309

Merged
merged 31 commits into from Jan 27, 2022
Merged

Conversation

VincentRPS
Copy link
Contributor

Summary

Adds Documentation for application commands, also overhauls the docs somewhat

Supersedes the pull on alento's fork.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Member

@ooliver1 ooliver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just these things (brackets and Bot with command prefix of /) left before ill approve

docs/index.rst Show resolved Hide resolved
docs/interactions.rst Show resolved Hide resolved
examples/application_commands/options.py Outdated Show resolved Hide resolved
examples/application_commands/message_command.py Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/user_command.py Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/message_command.py Outdated Show resolved Hide resolved
examples/application_commands/slash_command.py Outdated Show resolved Hide resolved
examples/application_commands/sub_commands.py Outdated Show resolved Hide resolved
examples/application_commands/user_command.py Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/migrating.rst Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/slash_command.py Outdated Show resolved Hide resolved
@ooliver1 ooliver1 added this to the 2.0.0 milestone Dec 28, 2021
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
@vcokltfre vcokltfre added p: medium Priority: medium - should be worked on in the near future s: in progress Status: the issue or PR is in development/progress t: docs Type: docs - improvements or additions to documentation labels Dec 31, 2021
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Show resolved Hide resolved
examples/application_commands/user_command.py Outdated Show resolved Hide resolved
examples/application_commands/user_command.py Outdated Show resolved Hide resolved
examples/application_commands/user_command.py Outdated Show resolved Hide resolved
Co-authored-by: Epic <tagepicuwu@gmail.com>
@netlify
Copy link

netlify bot commented Jan 12, 2022

✔️ Deploy Preview for nextcord-gh-action ready!

🔨 Explore the source changes: 3ccfeb7

🔍 Inspect the deploy log: https://app.netlify.com/sites/nextcord-gh-action/deploys/61ec9817a703750007cb64ff

😎 Browse the preview: https://deploy-preview-309--nextcord-gh-action.netlify.app

docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
docs/interactions.rst Outdated Show resolved Hide resolved
examples/application_commands/autocompleted_command.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/cog_example.py Outdated Show resolved Hide resolved
examples/application_commands/options.py Outdated Show resolved Hide resolved
examples/application_commands/slash_command.py Outdated Show resolved Hide resolved
@veni-vidi-code
Copy link
Collaborator

✔️ Deploy Preview for nextcord-gh-action ready!

🔨 Explore the source changes: 3ccfeb7

🔍 Inspect the deploy log: https://app.netlify.com/sites/nextcord-gh-action/deploys/61ec9817a703750007cb64ff

😎 Browse the preview: https://deploy-preview-309--nextcord-gh-action.netlify.app

I am not sure if these are still up to date in the corresponding part,but if i dislike the way Command Options display the option types below. I think this should be done differently for the docs



def setup(bot):
bot.add_cog(ApplicationCommandCog(bot)) # adds the cog to your bot.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you use standard Cogs while you document smth. above called ClientCog. I think this should be consistent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClientCog is only a internal class, it cant be used to do anything iirc



def setup(bot):
bot.add_cog(ApplicationCommandCog(bot)) # adds the cog to your bot.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClientCog is only a internal class, it cant be used to do anything iirc

@TAG-Epic TAG-Epic merged commit 4e8b6a1 into nextcord:master Jan 27, 2022
@VincentRPS VincentRPS deleted the docs branch January 27, 2022 12:51
@EmreTech EmreTech removed the s: in progress Status: the issue or PR is in development/progress label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: medium Priority: medium - should be worked on in the near future t: docs Type: docs - improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants