feat: asynchronousifying setup function in cogs

[MaskDuck]

Summary

NOTE: THIS WILL RAISE AN KEYBOARDINTERRUPT IF YOU ARE DOING AS SKELMIS SAYS AND IS ENDING THE BOT USING CONTROL + C

setup to be awaitable, fix issue #468

Checklist

• If code changes were made then they have been tested. (pls help)
  • I have updated the documentation to reflect the changes. (pls help)
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed) (uh not really, but yeah)
• This PR is not a code change (e.g. documentation, README, ...)

[netlify]

✅ Deploy Preview for nextcord-gh-action ready!

Name	Link
🔨 Latest commit	82be889
🔍 Latest deploy log	https://app.netlify.com/sites/nextcord-gh-action/deploys/623c567a31cecd00087c763e
😎 Deploy Preview	https://deploy-preview-536--nextcord-gh-action.netlify.app/faq
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[Skelmis]

Please make your pull request name better, ideally following cc.
Something like feat: Allow cog setup to be async

[Skelmis]

I personally disagree with making this a breaking change, especially given the overall use-case from what I have seen. Yes, some form of async loading is nice for a minority, however, enforcing the syntax proposed essentially removes .run which is what the majority of bots uses.

[Soheab]

You could use nextcord.utils.maybe_coroutine() for this.

[Skelmis]

You could use nextcord.utils.maybe_coroutine() for this.

This requires making load_ext.. async, which I have already commented on.

[ooliver1]

make an faq entry on the error that may be risen as discussed

[DenverCoder1]

In extensions.rst this should be changed. You can remove "This setup must be a plain Python function (not a coroutine)."

An extension at its core is a python file with an entry point called setup. This setup must be a plain Python function (not a coroutine). It takes a single parameter -- the :class:~.commands.Bot that loads the extension.

[ooliver1]

also perhaps handle error then raise an error which shows the faq entry perhaps

[Skelmis]

guys i have tested the code

. . . . .

Have you also tested backwards compatibility?

[Skelmis]

(if you mean plain python func setup then i have also tested)

Sounds good

[Skelmis]

TIL asyncio.run is indeed not blocking. So ty for that

However, still not removing the requested changes however as it is bad practice since it's creating two loops (I think) and either of the two calls should be the entry point for the bot.

async def main():
    bot.load_extension("cog_name")
    await bot.start("TOKEN")


asyncio.run(main())

Tested on your fork works fine and as expected

[Skelmis]

Code?

Alternately you can create a task instead, and then use bot.run

[Skelmis]

LGTM and I've tested on:

• 3.8.5
• 3.9.6
• 3.10.0