Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(client): fix nextcord.new mistake #854

Merged
merged 2 commits into from
Oct 20, 2022
Merged

docs(client): fix nextcord.new mistake #854

merged 2 commits into from
Oct 20, 2022

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Oct 20, 2022

Summary

This fixes the nextcord.new mistake in Client.fetch_template. Assuming that the Search & Replace replaced that on the big rename.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@DenverCoder1
Copy link
Collaborator

Check line 1424 also

@spifory
Copy link
Collaborator Author

spifory commented Oct 20, 2022

Check line 1424 also

Fixed in bcdd2e6

@ooliver1 ooliver1 added t: docs Type: docs - improvements or additions to documentation s: awaiting review Status: the issue or PR is awaiting reviews p: medium Priority: medium - should be worked on in the near future labels Oct 20, 2022
@ooliver1 ooliver1 removed the s: awaiting review Status: the issue or PR is awaiting reviews label Oct 20, 2022
@ooliver1 ooliver1 merged commit f50b790 into nextcord:master Oct 20, 2022
@spifory spifory deleted the toolifelsstocode/docs/fix-nextcord.new-mistake branch October 20, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

@ooliver1 ooliver1 ooliver1 approved these changes

Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future t: docs Type: docs - improvements or additions to documentation
Projects
No open projects
Nextcord progress
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spifory @DenverCoder1 @ooliver1