feat: on_application_command event #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmreTech
changed the title
EmreTech
added
t: enhancement
EmreTech
requested changes
Dec 31, 2022
| @@ -1374,6 +1374,8 @@ def parse_message_reaction_remove_emoji(self, data) -> None: | |||
|
|
|||
| def parse_interaction_create(self, data) -> None: | |||
| interaction = self._get_client().get_interaction(data=data) | |||
| if data["type"] == 2: # application command | |||
| self.dispatch("application_command", interaction) | |||
There was a problem hiding this comment.
It would be nice to provide the corresponding application command object with this event because Interaction.application_command hasn't been set at this point.
EmreTech
reviewed
Dec 31, 2022
|
|
||
| .. versionadded:: 2.4 | ||
|
|
||
| :param interaction: The interaction object containing the command information. |
There was a problem hiding this comment.
As I told you in a previous review comment, the interaction object at the time of dispatch doesn't actually contain the application command object.
Co-authored-by: Emre Terzioglu <50607143+EmreTech@users.noreply.github.com>
|
i do not have enough energy to continue this PR. |
EmreTech
removed
the
s: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #958
Checklist
task pyrightand fixed the relevant issues.