refactor: use ffprobe even if located under /usr/bin

[dotlambda]

Summary

If I call _probe_codec_native(source, "/bin/ffmpeg") I want it to use /bin/ffprobe.

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.
• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed)
• This PR is not a code change (e.g. documentation, README, ...)

[ooliver1]

Generally you have user installed binaries in /usr/bin. I'm not against this change but the reason is a bit odd, shouldn't that be in your $PATH?

[dotlambda]

Generally you have user installed binaries in /usr/bin.

True, I just wanted to shorten the commit message.

I'm not against this change but the reason is a bit odd, shouldn't that be in your $PATH?

Not necessarily. I might e.g. want to test it with an ffmpeg executable I compiled locally to test a change in ffmpeg.

[teaishealthy]

Just a general question, shouldn't proper path manipulation be used for this?
Path(executable).parent / "ffprobe" or similar

[dotlambda]

You're right. I think

Suggested change

	exe = executable[:-4] + "probe" if executable.endswith(("ffmpeg", "avconv")) else executable
	exe = Path(executable).parent / "ffprobe" if Path(executable).name in ("ffmpeg", "avconv") else executable

makes the most sense.

[Skelmis]

Hey @dotlambda, just bumping this. How are you feeling regarding the requested review comments?

[ooliver1]

Not necessarily. I might e.g. want to test it with an ffmpeg executable I compiled locally to test a change in ffmpeg.

That would then be /usr/local/bin, the order of your PATH variable would determine which binary is used.

[Skelmis]

I do not necessarily agree with this for the sake of a change which may only benefit a small subset of users. Can you provide some further reasoning why the library should do this as a default versus you as a developer simply setting an item in the PATH with a higher precedence to be used?

Also some context around how the change actually works given it flips the string substringing order would be appreciated

[ooliver1]

Closed for the above reasons with no response.

[dotlambda]

Can you provide some further reasoning why the library should do this as a default versus you as a developer simply setting an item in the PATH with a higher precedence to be used?

My specific use case is in Nixpkgs where I want to set a default ffmpeg executable that's used by any user of nextcord. I can't set PATH for those users because they import a Python module rather than run an executable.
So what I'm trying to achieve is the ability to set executable to an absolute path.