Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not properly initialize listeners with empty AETitle (patch) #4063

Closed
rbeckman-nextgen opened this issue May 11, 2020 · 2 comments
Closed

Does not properly initialize listeners with empty AETitle (patch) #4063

rbeckman-nextgen opened this issue May 11, 2020 · 2 comments
Milestone

Comments

@rbeckman-nextgen
Copy link
Collaborator

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Currently, mirth will assign the aetitle 'DCMRCV' when an empty value is present. this is stopping mirth from functioning as a 'DICOM Router' because it cannot be configured to answer to arbitrary AETitles.

this patch fixes it:

$ diff DICOMReceiver.java DICOMReceiver.java.fixed
95c95,97
< }

        } else {
      dcmrcv.setAEtitle(null);
  }

this was requested by a few users already:
http://www.mirthproject.org/community/forums/showthread.php?t=216647
http://www.mirthproject.org/community/forums/showthread.php?t=10690

Imported Issue. Original Details:
Jira Issue Key: MIRTH-4186
Reporter: gilbahat
Created: 2017-06-20T12:11:52.000-0700

@rbeckman-nextgen rbeckman-nextgen added this to the 3.6.0 milestone May 11, 2020
@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

OS(s) and JRE version: virtual Window 7 with JRE version 1.8.0_111-b14
Version(s)/Build(s) to reproduce failure: mirthconnect-3.5.0.8232.b2153-windows-x64.zip
Version(s)/Build(s) to verify fixes:
mirthconnect-3.6.0.8249.b2163-windows-x64
mirthconnect-3.5.0.8250.b178-windows-x64
Verified Fixed:
TEST 1: Sender AE is not set, Listener AE is not set
TEST 2: Sender AE set, Listener AE is not set
TEST 3: Sender AE set, Listener AE set to match
TEST 4: Sender AE set, Listener AE set to not match
Observations:

  • When using AE = blank on DICOM Sender, they are will be set to
    ||Scope|| Variable || Value || Notes||
    |Source| localApplicationEntityTitle |DCMRCV |(=> Remote Application Entity on DICOM Sender Settings)
    |Source| remoteApplicationEntityTitle |DCMSND |(=> Local Application Entity on DICOM Sender Settings)|
  • ApplicationEntity is case-sensitive

Imported Comment. Original Details:
Author: minht
Created: 2017-07-10T14:10:45.000-0700

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Verified by ROCKSOLID-1166

Imported Comment. Original Details:
Author: minht
Created: 2017-07-10T14:11:27.000-0700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.