Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore missing directories #46

Closed
fabik opened this issue Apr 14, 2016 · 3 comments
Closed

Ignore missing directories #46

fabik opened this issue Apr 14, 2016 · 3 comments

Comments

@fabik
Copy link
Contributor

fabik commented Apr 14, 2016

I am getting this error on CI, because basic-data directory does not exist. I am only using structures.

Directory "/home/ubuntu/wallet/tests/../app/../migrations/basic-data" does not exist.

Could you please ignore directories which do not exist?
@JanTvrdik
Copy link
Member

I aware of such behavior and I'm still undecided whether ignoring the error is a good idea.

#42 may provide better solution

@adaamz
Copy link
Contributor

adaamz commented Aug 30, 2017

+1
because you cannot simply commit empty directory to git repository. And what is difference between empty directory and non existimg directory?

@JanTvrdik
Copy link
Member

Non-existing directory may indicate critical bug in you migrations. Ignoring the error may break you application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JanTvrdik @fabik @adaamz