Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with PHP < 8.0 #38

Closed
peterpp opened this issue Dec 7, 2022 · 4 comments
Closed

Compatibility with PHP < 8.0 #38

peterpp opened this issue Dec 7, 2022 · 4 comments

Comments

@peterpp
Copy link

peterpp commented Dec 7, 2022

This library declares compatibility with PHP ^7.2 in composer.json. However, release 1.10.0 requires PHP 8.0. because it uses ReflectionClass::getAttributes() method.
@hrach
Copy link
Member

hrach commented Dec 7, 2022

Oh sorry, that's a bug. @haltuf would you please fix it?

@haltuf
Copy link
Contributor

haltuf commented Dec 7, 2022

@hrach @peterpp It's probably because of this line?

secured-links/src/SecuredLinksPresenterTrait.php

Line 71 in 63c7481

if (!$signalReflection->hasAnnotation('secured') && count($signalReflection->getAttributes(Secured::class)) === 0) {

We may add method_exists to keep to compatibility with PHP < 8

@haltuf haltuf mentioned this issue Dec 7, 2022
Merged
@hrach
Copy link
Member

hrach commented Dec 7, 2022

Fixed by #39

@hrach hrach closed this as completed Dec 7, 2022
@hrach
Copy link
Member

hrach commented Dec 7, 2022

Released as v1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hrach @haltuf @peterpp