refactor: safely store and close tasks #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAG-Epic
reviewed
Jul 12, 2023
TAG-Epic
requested changes
Jul 12, 2023
| for check, future in self._global_wait_for_handlers: | ||
| logger.debug("Dispatching to a global wait_for handler") | ||
| create_task(self._run_global_wait_for_handler(check, future, event_name, *args)) | ||
| async with create_task_group() as tg: |
There was a problem hiding this comment.
Wont this block until all callbacks have finished running? Because if so, that is going to cause issues.
There was a problem hiding this comment.
When the task encounters an
awaitstatement that requires the task to sleep until something happens, the event loop is then free to work on another task.
AnyIO Docs
It looks like it is blocking. I'm not sure what else to do though.
There was a problem hiding this comment.
Could a per-dispatcher task group be created?
TAG-Epic
added a commit
that referenced
this pull request
Jul 16, 2023
This also waits for error handlers. Conflicts with #253 is to be expected, sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to safely store then close any loose tasks in the code. AnyIO's task groups are used to safely handle tasks all being created to run coroutines (like the dispatcher and shard manager). Closes #190.