Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial jumping #142

Closed
clemofi opened this issue Jan 25, 2019 · 1 comment · Fixed by #201
Closed

Dial jumping #142

clemofi opened this issue Jan 25, 2019 · 1 comment · Fixed by #201

Comments

@clemofi
Copy link

clemofi commented Jan 25, 2019

If I change the dial interaction parameter to vertical and move the mouse fast while dragging, the value of the dial sometimes jumps to 0 or to 1 (depending on the value before). It seems that this is caused by the if statement in line 248 in dial.js which is of course needed for the radial interaction but (as far as i can see) is not necessary in vertical or horizontal interaction mode.
A fix could be to add something like && this.interaction === 'radial'

@taylorbf
Copy link
Contributor

taylorbf commented Mar 6, 2019

Thank you! I think you are exactly right. Will aim to add your suggestion in the next round of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants