Added serverVersion to API; bumped API version to 2.2 #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaosT
reviewed
Jan 13, 2017
| @@ -5,6 +5,7 @@ var hapLegacyTypes = require("hap-nodejs/accessories/types.js"); | |||
| var log = require("./logger")._system; | |||
| var User = require("./user").User; | |||
| var PlatformAccessory = require("./platformAccessory").PlatformAccessory; | |||
| var serverVersion = require("./version"); | |||
There was a problem hiding this comment.
I'm sorry but where is this serverVersion thing?
There was a problem hiding this comment.
What do you mean by "is"? Where it's used? On line 27
There was a problem hiding this comment.
Nah never mind, I was thinking something else.
KhaosT
reviewed
Jan 13, 2017
| @@ -20,7 +21,10 @@ function API() { | |||
| this._dynamicPlatforms = {}; // this._dynamicPlatforms[pluginName.platformName] = platform constructor | |||
|
|
|||
| // expose the homebridge API version | |||
| this.version = 2.1; | |||
| this.version = "2.1.1"; | |||
There was a problem hiding this comment.
Please bump this to number 2.2 instead of a string of "2.1.1"
maplesteve
changed the title
|
Alright, looks good to me :) |
|
Cool. Thanks! |
|
I'll try to see if there are any other changes going to happen, if not, I'm going to push this to npm probably later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm extending https://github.com/gismo141/homebridge-server and would like to show the version of homebridge there by using the homebridge API.