Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks that make use of information in idranges.toml #116

Closed
5 tasks done
dalito opened this issue Jul 2, 2023 · 0 comments · Fixed by #131
Closed
5 tasks done

Add checks that make use of information in idranges.toml #116

dalito opened this issue Jul 2, 2023 · 0 comments · Fixed by #131
Labels
enhancement Request for changing or improving existing features
Milestone
0.5.0

Comments

@dalito
Copy link
Member

dalito commented Jul 2, 2023 •
edited
Loading

The checks should catch errors which are critical for the vocabulary quality. The checks will be run as part of the vocabulary CI-pipeline. They give immediate feedback to the PR author if the submission needs more work.

Checks that require information from outside of the PR branch:

  • Does the PR add another vocabulary? (relevant only if single_vocab config-option is true)
  • Does the PR add only IRIs that have the correct form?
  • Does the PR add only IDs from the author's allowed range of IDs?

Checks that require information from outside of the PR branch:

  • are the added/changed vocabulary files (xlsx and ttl) correctly named?
  • Are any IDs present in the last released version deleted by the PR?

Do you have ideas for more checks?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for changing or improving existing features
Projects
None yet
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Add more checks & extend validation. Support vocabulary configuration. nfdi4cat/voc4cat-tool
1 participant
@dalito