Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add funding, acknolwledgement and license to isa.xlsx files #87

Open
andreaschrader opened this issue Dec 14, 2023 · 2 comments

Comments

@andreaschrader
Copy link
Member

andreaschrader commented Dec 14, 2023

Is your feature request related to a problem? Please describe.
While mapping and repeatedly having added funding, acknowledgement and license to the README in the root of several ARC, we feel that this is missing in the isa.xlsx:

Describe the solution you'd like
We suggest to add the following as comments to isa.xlsx:

  • funding_statement
  • funding_id
  • funder
  • license
  • acknowledgement
@HLWeil HLWeil transferred this issue from nfdi4plants/ARCCommander Dec 22, 2023
@kMutagene
Copy link
Member

@HLWeil if we decide to make the ARC a true extension of the ISA format, this should be real investigation metadata fields, not comments (in our standard) IMO. When doing ISA export, we can add them as comment. I think just using comments for everything that has no field in ISA is an unsustainable way moving forward

@HLWeil
Copy link
Member

HLWeil commented Jan 2, 2024

@andreaschrader @kMutagene this is an important, but difficult topic.

I see the need to include this information. But I think it won't stop there and conversions to other formats or checklists have the same constraints, with the Comment being currently used as a fall-back. This might lead to an ever growing amount of fixed fields in the specification.

Maybe another possible solution could be taking a similar route as with the Processes, using Key-Value pairs stemming from a controlled vocabulary. I think this would be the most logically consistent with the general philosophy of keeping it as generalizable as possible.

But there might be some technical constraints:

  • How could you integrate this in the current ISA-XLSX?
  • Is there a way to attach these Key-Value pairs as PropertyValues in the ARC RO-Crate?

@kMutagene kMutagene added this to the ARC-specification v3.0.0 milestone Jun 12, 2024
@kMutagene kMutagene added the Status: Needs Triage This item is up for investigation. label Jun 12, 2024
@kMutagene kMutagene mentioned this issue Jun 12, 2024
@HLWeil HLWeil removed the Status: Needs Triage This item is up for investigation. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In discussion
Development

No branches or pull requests

3 participants