New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new equals overrides for testing CvParam equality in ARCTokenizarion tests #33

Open

kMutagene opened this issue Aug 23, 2023 · 0 comments

Member

kMutagene commented Aug 23, 2023

Currently, equality is only tested by comparing some member values:

ARCTokenization/tests/ARCTokenization.Tests/TestUtils.fs

Lines 58 to 62 in 243020e

    
           let structuralEquality (cvpExpectec : CvParam) (cvpActual : CvParam) = 
        
               termNamesEqual cvpExpectec cvpActual 
        
               accessionsEqual cvpExpectec cvpActual 
        
               refUrisEqual cvpExpectec cvpActual 
        
               valuesEqual cvpExpectec cvpActual

Since #32 adds custom equality overrides, we should use those when it is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment