Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoCompleteTextField. emailDomain #14

Closed
lfarah opened this issue Jul 17, 2016 · 8 comments
Closed

autoCompleteTextField. emailDomain #14

lfarah opened this issue Jul 17, 2016 · 8 comments

Comments

@lfarah
Copy link
Contributor

lfarah commented Jul 17, 2016

I believe that most people will use AutoCompleteTextField as an autocomplete for emails, so instead of having them copy and paste that huge domainNames array, we could have something like that:

public func autoCompleteTextFieldDataSource(autoCompleteTextField: AutoCompleteTextField) -> [String] {

        return autoCompleteTextField.emailDomain
}
@lfarah lfarah changed the title autoCompleteTextField.Email autoCompleteTextField. emailDomain Jul 17, 2016
@nfhipona
Copy link
Owner

ahh good idea! I will make a default supported domains and they could just use the datasource to let their own supported domains kick in. 👌

@lfarah
Copy link
Contributor Author

lfarah commented Jul 19, 2016

Maybe something like this?

let myTextField = AutoCompleteTextField(frame: CGRectMake(0, 0, 100, 30))
myTextField.type = .email

@nfhipona
Copy link
Owner

nfhipona commented Jul 21, 2016

ohhh that could also be an option for email or name collections. but I don't think we should support names since it was so huge of a collection. if they want this to get hooked, they can use the datasource to load their own collection.

@lfarah
Copy link
Contributor Author

lfarah commented Jul 22, 2016

Definitely! 👍

@nfhipona
Copy link
Owner

Added default supported domains.

@lfarah
Copy link
Contributor Author

lfarah commented Jul 22, 2016

Now we have to update the Readme.md

@nfhipona
Copy link
Owner

nfhipona commented Aug 1, 2016

Okay thanks for the note.

@nfhipona nfhipona reopened this Aug 1, 2016
@nfhipona
Copy link
Owner

nfhipona commented Aug 1, 2016

Updated

@nfhipona nfhipona closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants