Small changes #21
Merged
Small changes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for RxSwift to see the updated result.
nfhipona
approved these changes
Jul 4, 2017
nfhipona
approved these changes
Jul 4, 2017
nfhipona
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple small changes that I needed to use AutoCompleteTextField in my project.
The pod spec for including xcassets needed to be tweaked or it the checkmark images wouldn't be bundled.
I use RxSwift and if the user let the text field be autocomplete it wasn't registering the correct value in RxSwift. Sending a value changed action event fixed it for me.
Thank you for the work you've put into this & sorry that the PR items aren't separated. I did the work all on one branch and didn't think about it until it was too late.