Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiftlint #7

Closed
lfarah opened this issue Jul 14, 2016 · 4 comments
Closed

Swiftlint #7

lfarah opened this issue Jul 14, 2016 · 4 comments

Comments

@lfarah
Copy link
Contributor

lfarah commented Jul 14, 2016

I'd be cool to add Swiftlint and it's very easy to install.
I already fixed all the Swiftlint warnings for AutoCompleteTextField, so It's all about installing and then I can make a pull request 馃槃

@nfhipona
Copy link
Owner

nfhipona commented Jul 14, 2016

@lfarah Swiftlint is only to verify the mistakes of the coder when initializing objects right? I don't think we need this, but let me have some of your thoughts of why we are needing this. Thanks!

@lfarah
Copy link
Contributor Author

lfarah commented Jul 14, 2016

Swiftlint helps in following the Swift Guidelines. I fixed about 20 erros in AutoCompleteTextField, most of them being in CGRectMake(), that has to be CGRect(x:,y:,:width:,height:), }else{ that had to be } else {, CGRectZero that had to be CGRect.zero.
I always add Swiftlint to all my projects and it's soooo useful. I really love it!

@nfhipona
Copy link
Owner

Ah yes. Those part was actually an Obj-C type initialization. I have issues with compiler before when it was xcode 6.0 it was having too many sourcekit errors. I will keep this in mind thanks! I think let's decide this one later whether really need it or not. I'll be updating this tomorrow night around this time when I'm in my workstation. :)

@nfhipona
Copy link
Owner

@lfarah okay updated. All are conforming to swift syntax and there should be no more ObjC syntax traces. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants