Removed typing_extensions requirement, and updated Pipfiles to match. #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @RONNCC |
dotlambda
added a commit
to dotlambda/pytube
that referenced
this pull request
Mar 28, 2021
setup.py was forgotten by pytube#801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README has stated that pytube is dependency-free for quite a while, but this isn't entirely true -- the
typing_extensionslibrary was added while hbmartin was developing pytube 3.This removes that depenency from pytube, which was only relevant for two type annotations in
monostate.py, so pytube can truly be dependency-free.